Migrate grpc-web-node-http-transport package so it's under the @improbable-eng org. on npm. #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bable-eng org. on npm. To further disambiguate that this transport is specifically for use with the `@improbable-eng/grpc-web` package. Note I've also fixed an issue with the dependencies; `@improbable-eng/grpc-web` should have been listed as a peer-dependency as it's intended to be used as a plugin (ie: the consumer is expected to have `@improbable-eng/grpc-web` somewhere in their dependency tree)
johanbrandhorst
approved these changes
Jan 13, 2019
| @@ -27,7 +27,6 @@ | |||
| "dist" | |||
| ], | |||
| "peerDependencies": { | |||
| "@types/google-protobuf": "^3.2.5", | |||
There was a problem hiding this comment.
I'm almost certain this was a mistake.
This package provides TypeScript definitions which are only required during compilation (and already satisfied as a devDependency); consumers do not need to fulfil this dependency as they are not expected to compile this package.
| "@types/node": "^10.12.0", | ||
| "google-protobuf": "^3.2.0", |
There was a problem hiding this comment.
...to satisfy @improbable-eng/grpc-web's peerDependency
jonny-improbable
deleted the
feature/migrate-node-http-transport-package-name
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To further disambiguate that this transport is specifically for use with the
@improbable-eng/grpc-webpackage.Note I've also fixed an issue with the dependencies;
@improbable-eng/grpc-webshould have been listed as a peer-dependency as it's intended to be used as a plugin (ie: the consumer is expected to have@improbable-eng/grpc-websomewhere in their dependency tree).